Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for auth guard method calls on auth helper and facade #317

Merged
merged 3 commits into from
Oct 5, 2019
Merged

Fix for auth guard method calls on auth helper and facade #317

merged 3 commits into from
Oct 5, 2019

Conversation

canvural
Copy link
Collaborator

@canvural canvural commented Oct 3, 2019

Fixes #309

Also adds tests for user, check and id method calls on both auth helper and facade.

I'm not %100 sure if this does not break anything else (auth related) but according to my tests, it looks fine.

@szepeviktor
Copy link
Collaborator

szepeviktor commented Oct 3, 2019

Thank you for your work!

@canvural Could it be that your commits were made with a non-GitHub email from aequitas-group.pl?

@canvural
Copy link
Collaborator Author

canvural commented Oct 3, 2019

@szepeviktor Ah, yes. I was working on my work laptop. Forgot to change the address. Is that gonna be a problem?

@szepeviktor
Copy link
Collaborator

szepeviktor commented Oct 3, 2019

Not for this repo, maybe for you.
Force-push could be an option!

@nunomaduro nunomaduro merged commit ea7aee4 into larastan:master Oct 5, 2019
@canvural canvural deleted the fix-auth branch October 5, 2019 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Call to an undefined method Illuminate\Contracts\Auth\Factory::xxx()
3 participants