Adds support for resolving types of model relations accessed as property #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome job. Thanks! |
|
@canvural Don't hesitate in adding your github sponsors page into the funding github. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for specifying types for model relations accessed as model properties.
$user->postsfor example, returns a collection of posts.There is one thing though. I had to remove
Illuminate\Database\Eloquent\Modelfrom theuniversalObjectCratesClassesfor this to work. So this can result in some new errors for the users. Because now all the property accesses will be checked by PHPStan. But as I said, this is also required for this extension to work.