Fix incorrect boolean type cast #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks for the PR! Can you explain why this is necessary? Cause here the type resolver would convert both |
|
@canvural In old logic, if The core of this PR is this line: https://github.com/nunomaduro/larastan/pull/513/files#diff-8c4331b9e7c6c4544f1895befdc48f1dR198 |
canvural
approved these changes
Mar 31, 2020
|
In that case, you are right 👍 Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Boolean properties were cast to
booleanhere:https://github.com/nunomaduro/larastan/blob/master/src/Properties/ModelPropertyExtension.php#L233
So we need to compare
$column->readableTypewithbooleaninstead ofbool