Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Probable fix for #559 #561

Merged
merged 3 commits into from
May 5, 2020
Merged

Probable fix for #559 #561

merged 3 commits into from
May 5, 2020

Conversation

ondrejmirtes
Copy link
Contributor

@ondrejmirtes ondrejmirtes commented May 4, 2020 •
edited by szepeviktor
Loading

Fixes #559

@ondrejmirtes ondrejmirtes mentioned this pull request May 4, 2020
Closed
@ondrejmirtes ondrejmirtes force-pushed the fix-559 branch 2 times, most recently from 7403cce to 49054c5 Compare May 5, 2020 06:09
@ondrejmirtes
Copy link
Contributor Author

So the failing test is there because PHPStan defines global resolve function - because it includes an unprefixed Hoa library. I'll see if I can do without that today.

But this PR definitely fixes the issue with the autoloader.

@ondrejmirtes
Copy link
Contributor Author

/cc @canvural @nunomaduro

@ondrejmirtes
Copy link
Contributor Author

Just pushed a commit that requires current dev-master of PHPStan - and it works :) This is what fixes it: phpstan/phpstan-src@70e559b (diff of a diff - how meta!)

So we should merge this - once we do, I'll release PHPStan 0.12.23 and you should release v0.5.8.

@nunomaduro nunomaduro merged commit ea2362b into larastan:master May 5, 2020
@nunomaduro
Copy link
Collaborator

Testing things out locally now..

@ondrejmirtes ondrejmirtes deleted the fix-559 branch May 5, 2020 12:23
@ondrejmirtes
Copy link
Contributor Author

Let me know somewhere when you're ready to release it, I'll tag PHPStan 0.12.23 before you :)

@szepeviktor
Copy link
Collaborator

Thank you.

@nunomaduro
Copy link
Collaborator

Tested locally in Laravel and Laravel packages. Tests are passing locally and on the CI.

Everything sounds good to me. @ondrejmirtes Please release the new version, and I will follow you on that.

@ondrejmirtes
Copy link
Contributor Author

Released: https://github.com/phpstan/phpstan/releases/tag/0.12.23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szepeviktor szepeviktor szepeviktor approved these changes

@nunomaduro nunomaduro Awaiting requested review from nunomaduro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug with autoloading on phpstan 0.12.22
3 participants
@ondrejmirtes @nunomaduro @szepeviktor