Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix false positive for NoUnnecessaryCollectionCallRule #609

Merged
merged 4 commits into from
Jun 29, 2020
Merged

Fix false positive for NoUnnecessaryCollectionCallRule #609

merged 4 commits into from
Jun 29, 2020

Conversation

Daanra
Copy link
Contributor

@Daanra Daanra commented Jun 29, 2020 •
edited
Loading

  • Added or updated tests
  • Documented user facing changes
  • Updated CHANGELOG.md

Resolves #607

Changes

Fix false positive for NoUnnecessaryCollectionCallRule when statically calling hydrate on a Model class.

@szepeviktor
Copy link
Collaborator

Thank you @Daanra

@szepeviktor szepeviktor merged commit c606cc5 into larastan:master Jun 29, 2020
@nunomaduro
Copy link
Collaborator

@canvural are you ok with this?

@canvural
Copy link
Collaborator

@canvural are you ok with this?

Yeah, looks good 👍 Thanks @Daanra

@szepeviktor szepeviktor removed the request for review from canvural June 29, 2020 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nunomaduro nunomaduro nunomaduro approved these changes

@szepeviktor szepeviktor szepeviktor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using Model::hydrate()->first() throws error
4 participants
@Daanra @szepeviktor @nunomaduro @canvural