Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct return type for firstWhere method on model, builder and relations #649

Merged
merged 4 commits into from
Sep 2, 2020
Merged

fix: correct return type for firstWhere method on model, builder and relations #649

merged 4 commits into from
Sep 2, 2020

Conversation

canvural
Copy link
Collaborator

@canvural canvural commented Sep 2, 2020

  • Added or updated tests
  • Documented user facing changes
  • Updated CHANGELOG.md

Fixes #647

Changes

This PR fixes the return type of firstWhere method called on model, builder and relations.

@canvural canvural changed the title fix: correct return type for firstWhere method on model, builder and relations fix: correct return type for firstWhere method on model, builder and relations Sep 2, 2020
@canvural canvural merged commit 18177fd into master Sep 2, 2020
@canvural canvural deleted the firstWhere-patch branch September 2, 2020 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Access to an undefined property on models
2 participants
@canvural @nunomaduro