Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: php8 support #701

Merged
merged 2 commits into from
Oct 30, 2020
Merged

feat: php8 support #701

merged 2 commits into from
Oct 30, 2020

Conversation

canvural
Copy link
Collaborator

Resolves #687

@canvural
Copy link
Collaborator Author

Thanks @szepeviktor I wasn't sure if it was 8.0 or nightly in Travis

BTW it takes reaaaaaly long time to start the builds. 🙁

@szepeviktor
Copy link
Collaborator

szepeviktor commented Oct 27, 2020 •
edited
Loading

TravisCI is a nice and mature product and is very free :)
Currently many of us use it:

kép

GHA is a not so great product.

@canvural canvural marked this pull request as ready for review October 30, 2020 08:48
@canvural canvural changed the title WIP: feat: php8 support feat: php8 support Oct 30, 2020
@nunomaduro nunomaduro merged commit 98a631d into master Oct 30, 2020
@nunomaduro nunomaduro deleted the php-8 branch October 30, 2020 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support PHP 8
3 participants
@canvural @szepeviktor @nunomaduro