Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mixin pipe #704

Merged
merged 3 commits into from
Nov 28, 2020
Merged

Remove mixin pipe #704

merged 3 commits into from
Nov 28, 2020

Conversation

canvural
Copy link
Collaborator

@canvural canvural commented Oct 29, 2020

  • Added or updated tests
  • Documented user facing changes
  • Updated CHANGELOG.md

Changes

This PR removes the mixin pipe class. PHPStan has native support for @mixin annotations so this class is not needed anymore. And after removing it, there were a couple of issues, those are also fixed.

@canvural canvural force-pushed the remove-mixin-pipe branch 2 times, most recently from 483f4f4 to c9693d8 Compare October 29, 2020 10:50
Copy link
Collaborator

@nunomaduro nunomaduro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

canvural and others added 2 commits November 28, 2020 13:19
[ci skip] [skip ci]
Apply fixes from StyleCI

[ci skip] [skip ci]
@canvural canvural merged commit 76dbd9a into master Nov 28, 2020
@canvural canvural deleted the remove-mixin-pipe branch November 28, 2020 13:33
shaffe-fr added a commit to shaffe-fr/larastan that referenced this pull request Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants