Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support for HigherOrderCollectionProxy #781

Merged
merged 6 commits into from
Feb 8, 2021
Merged

feat: support for HigherOrderCollectionProxy #781

merged 6 commits into from
Feb 8, 2021

Conversation

canvural
Copy link
Collaborator

@canvural canvural commented Feb 7, 2021 •
edited
Loading

  • Added or updated tests
  • Documented user facing changes
  • Updated CHANGELOG.md

Closes #200

Changes

This PR adds support for HigherOrderCollectionProxy

Larastan now correctly understands, for example

User::all()->each->markAsActive();

returns a collection and markAsActive is called on User class

Breaking changes

None

nunomaduro
nunomaduro approved these changes Feb 7, 2021
View reviewed changes
Copy link
Collaborator

@nunomaduro nunomaduro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@canvural canvural merged commit 96c3c37 into master Feb 8, 2021
@canvural canvural deleted the feat/higher-order-proxy branch February 8, 2021 22:55
@szepeviktor
Copy link
Collaborator

@nunomaduro Should we remove the usage restriction from the docs?
https://github.com/nunomaduro/larastan/pull/781/files#diff-e1c8ae9befcb1158c5229a3c4ea6816341403517e46c72de2b9ead8a8b377cd2

@jkniest
Copy link

jkniest commented Feb 9, 2021

Awesome! Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nunomaduro nunomaduro nunomaduro approved these changes

@szepeviktor szepeviktor szepeviktor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Higher Order Proxy functions
4 participants
@canvural @szepeviktor @jkniest @nunomaduro