feat: support sole method #822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szepeviktor
approved these changes
Apr 22, 2021
|
@canvural As I was expected the sole presence of the docblock on the other versions is failing the tests. |
|
Ah, you are right. I totally forgot about that. I'm sorry! Ok then let's remove it and hope PHPStan merges definitions from stubs and actual method reflections 😄 |
Stubs are there specifically to overwrite - potentially incorrect - PHPDoc blocks in the source code. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add support for the
solemethod on Laravel 8.(sorry I did something wrong and it auto-close the previous PR… Don't really know why…)