Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use checkExplicitMixed PHPStan option when running tests #844

Merged
merged 1 commit into from
Jun 12, 2021

Conversation

canvural
Copy link
Collaborator

@canvural canvural commented Jun 12, 2021

  • Added or updated tests
  • Documented user facing changes
  • Updated CHANGELOG.md

Changes
This PR uses checkExplicitMixed PHPStan option when running tests. This can help us catch some false positives. Already caught a bug regarding model property type casting.

Breaking changes

n/a

@canvural canvural merged commit 884b701 into master Jun 12, 2021
@canvural canvural deleted the checkExplicitMixed branch June 12, 2021 14:44
@szepeviktor
Copy link
Collaborator

@canvural
Copy link
Collaborator Author

phpstan.org/config-reference#checkexplicitmixedmissingreturn

Oh, thank you. I'll try that and see if it's useful to us.

@szepeviktor
Copy link
Collaborator

Oh nooo!
I wanted to link the docs of checkExplicitMixed but it turns out it is undocumented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants