Revert "fix bootstrap path (#852)" #858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d8d1a90.
|
Notice: when we sort out the location of app.php we should re-add those tests. |
szepeviktor
approved these changes
Jul 2, 2021
|
So are we sure this fixes things for everyone now? 😃 |
|
@szepeviktor |
There are some minor use cases like, running larastan from out of working directories, but this revert should be fine for majority of people (because the were no issues before my #852 😄 ) @szepeviktor @canvural |
|
@rajyan Thank you! Should I tag a new release now or there are things to be changed more? |
|
@canvural |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit d8d1a90.
reverts as it was a breaking change for people using symlinks.
fixes #856
Changes
reverts #852
Breaking changes