Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Class diagrams contain additional graphic icons #411

Open
nus-pe-bot opened this issue Nov 17, 2023 · 1 comment
Open

Class diagrams contain additional graphic icons #411

nus-pe-bot opened this issue Nov 17, 2023 · 1 comment

Comments

@nus-pe-bot
Copy link

nus-pe-bot commented Nov 17, 2023

Note from the teaching team: This bug was reported during the Part II (Evaluating Documents) stage of the PE. You may reject this bug if it is not related to the quality of documentation.



Class diagrams should not have additional graphic modifiers (such as C, I, and A) as per the CS2113 textbook.

This applies to all class diagrams throughout the DG.

image.png


[original: nus-cs2113-AY2324S1/pe-interim#343] [original labels: type.DocumentationBug severity.VeryLow]
@DextheChik3n
Copy link
Contributor

Team's Response

Yes, we do agree that we should have removed the extra graphics and changed the coloured symbols for the visibility attribute to use the standard notation. Thank you for raising this issue.

Duplicate status (if any):

--

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment