Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prof Comments #26

Closed
helloqx opened this issue Mar 14, 2017 · 4 comments
Closed

Prof Comments #26

helloqx opened this issue Mar 14, 2017 · 4 comments
Assignees

Comments

@helloqx
Copy link
Contributor

helloqx commented Mar 14, 2017

Commit message/changelog for modifying modules
Restore module button -> undo icon
Bold important info (module information)
Group changes into sections
Table Old Module and New Module

@tgqiang
Copy link
Contributor

tgqiang commented Mar 16, 2017

Commit message/changelog for modifying modules

@helloqx @nlzz22 @xaterz
Requires addition of change-log message tracking in backend (Use Case: "User can specify a message explaining/detailing reasons for the change applied to a module")

Restore module button -> undo icon

Change implemented.

Bold important info (module information)

Adjusted width of columns displaying module code and name to provide certain emphasis to the module (i.e. the columns for module code and name will, together, occupy a significant proportion of the table width)

Group changes into sections

@helloqx can recall which 'changes to be grouped into sections' were mentioned?

Also, the UI will depend on back-end, depending on what feature this applies to.

Table Old Module and New Module

Will be implementing child rows for the table that display changes in module details.
(i.e. clicking on a row will reveal a child row that displays comprehensive changes to module details)

UI for displaying other module changes are already revised accordingly.

@tgqiang
Copy link
Contributor

tgqiang commented Mar 16, 2017

UI revisions for specific module modifications currently work-in-progress.

@tgqiang
Copy link
Contributor

tgqiang commented Mar 17, 2017

Update: Modified Modules UI is 80% complete, left with back-end support for displaying modified module details for a target module with respect to issues #43 and #47.

@tgqiang
Copy link
Contributor

tgqiang commented Mar 19, 2017

First point in this issue extracted out to #54

Others are addressed or already addressed; this issue will be closed with resolution of #43 and #47 .

@tgqiang tgqiang closed this as completed Mar 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants