Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch lscolors to not blink #6210

Merged
merged 1 commit into from
Aug 2, 2022

Conversation

sholderbach
Copy link
Member

Description

Unreleased patch for the lscolors -> crossterm translation, where I
introduced a bug/incompatibility with several terminal emulators causing
blinking

#6172 (comment)

Refers to patch, can be replaced once a new lscolors version is
released:

sharkdp/lscolors#51

Tests

Make sure you've done the following:

  • Add tests that cover your changes, either in the command examples, the crate/tests folder, or in the /tests folder.
  • Try to think about corner cases and various ways how your changes could break. Cover them with tests.
  • If adding tests is not possible, please document in the PR body a minimal example with steps on how to reproduce so one can verify your change works.

Make sure you've run and fixed any issues with these commands:

  • cargo fmt --all -- --check to check standard code formatting (cargo fmt --all applies these changes)
  • cargo clippy --workspace --features=extra -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect to check that you're using the standard code style
  • cargo test --workspace --features=extra to check that all the tests pass

Unreleased patch for the `lscolors` -> `crossterm` translation, where I
introduced a bug/incompatibility with several terminal emulators causing
blinking

nushell#6172 (comment)

Refers to patch, can be replaced once a new `lscolors` version is
released:

sharkdp/lscolors#51
@sholderbach sholderbach changed the title Patch lscolor to not blink Patch lscolors to not blink Aug 2, 2022
@sholderbach sholderbach merged commit 7fc8ff6 into nushell:main Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant