Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REFACTOR: move the 0% commands to nu-cmd-extra #9404

Merged

Commits on Jun 10, 2023

  1. move fmt to nu-cmd-extra

    amtoine committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    2cd7527 View commit details
    Browse the repository at this point in the history
  2. move all other 0% commands

    Commands used:
    ```nu
    mkdir crates/nu-cmd-extra/src/extra/filters/ crates/nu-cmd-extra/src/extra/filters/roll/
    mv crates/nu-command/src/filters/each_while.rs crates/nu-cmd-extra/src/extra/filters/each_while.rs
    mv crates/nu-command/src/filters/update_cells.rs crates/nu-cmd-extra/src/extra/filters/update_cells.rs
    mv crates/nu-command/src/filters/rotate.rs crates/nu-cmd-extra/src/extra/filters/rotate.rs
    mv crates/nu-command/src/filters/roll/ crates/nu-cmd-extra/src/extra/filters/roll/
    
    mkdir crates/nu-cmd-extra/src/extra/strings/encode_decode/
    mv crates/nu-command/src/strings/encode_decode/hex.rs crates/nu-cmd-extra/src/extra/strings/encode_decode/_hex.rs
    mv crates/nu-command/src/strings/encode_decode/encode_hex.rs crates/nu-cmd-extra/src/extra/strings/encode_decode/encode_hex.rs
    mv crates/nu-command/src/strings/encode_decode/decode_hex.rs crates/nu-cmd-extra/src/extra/strings/encode_decode/decode_hex.rs
    mv crates/nu-command/src/strings/format/ crates/nu-cmd-extra/src/extra/strings/format/
    
    mkdir crates/nu-cmd-extra/src/extra/formats/to/ crates/nu-cmd-extra/src/extra/formats/from/
    mv crates/nu-command/src/formats/to/html.rs crates/nu-cmd-extra/src/extra/formats/to/html.rs
    mv crates/nu-command/src/formats/from/url.rs crates/nu-cmd-extra/src/extra/formats/from/url.rs
    
    mkdir crates/nu-cmd-extra/src/extra/platform/ansi/
    mv crates/nu-command/src/platform/ansi/gradient.rs crates/nu-cmd-extra/src/extra/platform/ansi/gradient.rs
    ```
    amtoine committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    e02a8c1 View commit details
    Browse the repository at this point in the history
  3. remove the old exports

    amtoine committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    1b4634f View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2023

  1. move the roll commands to the right location

    there was an extra level of depth
    amtoine committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    720880f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    daa3593 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    78f1152 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    84e3a55 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2023

  1. Merge commit '9547c106d' into refactor/move-0-percent-commands-to-extra

    this should solve the merge conflict in nushell#9404.
    amtoine committed Jul 1, 2023
    Configuration menu
    Copy the full SHA
    40d5501 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7b353c2 View commit details
    Browse the repository at this point in the history
  3. move assets for to html

    this solves the following error
    ```
    error: proc-macro derive panicked
      --> crates/nu-cmd-extra/src/extra/formats/to/html.rs:79:10
       |
    79 | #[derive(RustEmbed)]
       |          ^^^^^^^^^
       |
       = help: message: #[derive(RustEmbed)] folder '/home/amtoine/.local/share/git/store/github.com/amtoine/nushell/crates/nu-cmd-extra/assets/' does not exist. cwd: '/home/amtoine/.local/share/git/store/github.com/amtoine/nushell'
    
    error[E0599]: no function or associated item named `get` found for struct `Assets` in the current scope
       --> crates/nu-cmd-extra/src/extra/formats/to/html.rs:228:19
        |
    81  | struct Assets;
        | ------------- function or associated item `get` not found for this struct
    ...
    228 |     match Assets::get(json_name) {
        |                   ^^^ function or associated item not found in `Assets`
        |
        = help: items from traits can only be used if the trait is implemented and in scope
        = note: the following traits define an item `get`, perhaps you need to implement one of them:
                candidate #1: `SliceIndex`
                candidate #2: `RustEmbed`
    
    For more information about this error, try `rustc --explain E0599`.
    error: could not compile `nu-cmd-extra` due to 2 previous errors
    warning: build failed, waiting for other jobs to finish...
    ```
    amtoine committed Jul 1, 2023
    Configuration menu
    Copy the full SHA
    9eed1a2 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    142724a View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    ea27b6f View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    c79ad0b View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2023

  1. fix the tests of nushell#9404 (#4)

    * bring `enumerate` and `if` into `extra` tests
    
    * disable all failing tests when not in `extra`
    amtoine committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    86a2e3e View commit details
    Browse the repository at this point in the history
  2. Merge branch 'main' into refactor/move-0-percent-commands-to-extra

    this should solve the merge conflicts in nushell#9404.
    amtoine committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    6d7b120 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d589a05 View commit details
    Browse the repository at this point in the history