-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REFACTOR: move the 0% commands to nu-cmd-extra
#9404
Merged
stormasm
merged 16 commits into
nushell:main
from
amtoine:refactor/move-0-percent-commands-to-extra
Jul 6, 2023
Merged
REFACTOR: move the 0% commands to nu-cmd-extra
#9404
stormasm
merged 16 commits into
nushell:main
from
amtoine:refactor/move-0-percent-commands-to-extra
Jul 6, 2023
Commits on Jun 10, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 2cd7527 - Browse repository at this point
Copy the full SHA 2cd7527View commit details -
Commands used: ```nu mkdir crates/nu-cmd-extra/src/extra/filters/ crates/nu-cmd-extra/src/extra/filters/roll/ mv crates/nu-command/src/filters/each_while.rs crates/nu-cmd-extra/src/extra/filters/each_while.rs mv crates/nu-command/src/filters/update_cells.rs crates/nu-cmd-extra/src/extra/filters/update_cells.rs mv crates/nu-command/src/filters/rotate.rs crates/nu-cmd-extra/src/extra/filters/rotate.rs mv crates/nu-command/src/filters/roll/ crates/nu-cmd-extra/src/extra/filters/roll/ mkdir crates/nu-cmd-extra/src/extra/strings/encode_decode/ mv crates/nu-command/src/strings/encode_decode/hex.rs crates/nu-cmd-extra/src/extra/strings/encode_decode/_hex.rs mv crates/nu-command/src/strings/encode_decode/encode_hex.rs crates/nu-cmd-extra/src/extra/strings/encode_decode/encode_hex.rs mv crates/nu-command/src/strings/encode_decode/decode_hex.rs crates/nu-cmd-extra/src/extra/strings/encode_decode/decode_hex.rs mv crates/nu-command/src/strings/format/ crates/nu-cmd-extra/src/extra/strings/format/ mkdir crates/nu-cmd-extra/src/extra/formats/to/ crates/nu-cmd-extra/src/extra/formats/from/ mv crates/nu-command/src/formats/to/html.rs crates/nu-cmd-extra/src/extra/formats/to/html.rs mv crates/nu-command/src/formats/from/url.rs crates/nu-cmd-extra/src/extra/formats/from/url.rs mkdir crates/nu-cmd-extra/src/extra/platform/ansi/ mv crates/nu-command/src/platform/ansi/gradient.rs crates/nu-cmd-extra/src/extra/platform/ansi/gradient.rs ```
Configuration menu - View commit details
-
Copy full SHA for e02a8c1 - Browse repository at this point
Copy the full SHA e02a8c1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1b4634f - Browse repository at this point
Copy the full SHA 1b4634fView commit details
Commits on Jun 11, 2023
-
move the roll commands to the right location
there was an extra level of depth
Configuration menu - View commit details
-
Copy full SHA for 720880f - Browse repository at this point
Copy the full SHA 720880fView commit details -
Configuration menu - View commit details
-
Copy full SHA for daa3593 - Browse repository at this point
Copy the full SHA daa3593View commit details -
Configuration menu - View commit details
-
Copy full SHA for 78f1152 - Browse repository at this point
Copy the full SHA 78f1152View commit details -
Configuration menu - View commit details
-
Copy full SHA for 84e3a55 - Browse repository at this point
Copy the full SHA 84e3a55View commit details
Commits on Jul 1, 2023
-
Merge commit '9547c106d' into refactor/move-0-percent-commands-to-extra
this should solve the merge conflict in nushell#9404.
Configuration menu - View commit details
-
Copy full SHA for 40d5501 - Browse repository at this point
Copy the full SHA 40d5501View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7b353c2 - Browse repository at this point
Copy the full SHA 7b353c2View commit details -
this solves the following error ``` error: proc-macro derive panicked --> crates/nu-cmd-extra/src/extra/formats/to/html.rs:79:10 | 79 | #[derive(RustEmbed)] | ^^^^^^^^^ | = help: message: #[derive(RustEmbed)] folder '/home/amtoine/.local/share/git/store/github.com/amtoine/nushell/crates/nu-cmd-extra/assets/' does not exist. cwd: '/home/amtoine/.local/share/git/store/github.com/amtoine/nushell' error[E0599]: no function or associated item named `get` found for struct `Assets` in the current scope --> crates/nu-cmd-extra/src/extra/formats/to/html.rs:228:19 | 81 | struct Assets; | ------------- function or associated item `get` not found for this struct ... 228 | match Assets::get(json_name) { | ^^^ function or associated item not found in `Assets` | = help: items from traits can only be used if the trait is implemented and in scope = note: the following traits define an item `get`, perhaps you need to implement one of them: candidate #1: `SliceIndex` candidate #2: `RustEmbed` For more information about this error, try `rustc --explain E0599`. error: could not compile `nu-cmd-extra` due to 2 previous errors warning: build failed, waiting for other jobs to finish... ```
Configuration menu - View commit details
-
Copy full SHA for 9eed1a2 - Browse repository at this point
Copy the full SHA 9eed1a2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 142724a - Browse repository at this point
Copy the full SHA 142724aView commit details -
Configuration menu - View commit details
-
Copy full SHA for ea27b6f - Browse repository at this point
Copy the full SHA ea27b6fView commit details -
Configuration menu - View commit details
-
Copy full SHA for c79ad0b - Browse repository at this point
Copy the full SHA c79ad0bView commit details
Commits on Jul 6, 2023
-
fix the tests of nushell#9404 (#4)
* bring `enumerate` and `if` into `extra` tests * disable all failing tests when not in `extra`
Configuration menu - View commit details
-
Copy full SHA for 86a2e3e - Browse repository at this point
Copy the full SHA 86a2e3eView commit details -
Merge branch 'main' into refactor/move-0-percent-commands-to-extra
this should solve the merge conflicts in nushell#9404.
Configuration menu - View commit details
-
Copy full SHA for 6d7b120 - Browse repository at this point
Copy the full SHA 6d7b120View commit details -
Configuration menu - View commit details
-
Copy full SHA for d589a05 - Browse repository at this point
Copy the full SHA d589a05View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.