Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Bundlesize #1049

Merged
merged 3 commits into from Jul 27, 2018
Merged

Integrate Bundlesize #1049

merged 3 commits into from Jul 27, 2018

Conversation

ZhangYiJiang
Copy link
Member

Because Buildsize... frankly speaking has issues.

  • Isn't accurate
  • Bot comments too verbose
  • Doesn't account for gzip

Hopefully this will work better since it's CI integrated rather than living on a different server.

@buildsize
Copy link

buildsize bot commented Jul 15, 2018

File name Previous Size New Size Change
_redirects 73 bytes 73 bytes 0 bytes (0%)
apple-touch-icon.png 3.37 KB 3.37 KB 0 bytes (0%)
commit-hash.txt 8 bytes 8 bytes 0 bytes (0%)
index.html 3.63 KB 3.63 KB 0 bytes (0%)
manifest.json 394 bytes 394 bytes 0 bytes (0%)
opensearch.xml 696 bytes 696 bytes 0 bytes (0%)
robots.txt 32 bytes 32 bytes 0 bytes (0%)
safari-pinned-tab.svg 4.91 KB 4.91 KB 0 bytes (0%)
share.png 12.27 KB 12.27 KB 0 bytes (0%)
short_url.php 480 bytes 480 bytes 0 bytes (0%)
[hash].js 38.1 KB 38.1 KB 0 bytes (0%)
[hash].js.map 142.78 KB 142.78 KB 0 bytes (0%)
android-chrome-192x192.png 4.04 KB 4.04 KB 0 bytes (0%)
android-chrome-512x512.png 8.95 KB 8.95 KB 0 bytes (0%)
app.[hash].css 150.68 KB 150.68 KB 0 bytes (0%)
app.[hash].js 266.44 KB 266.44 KB 0 bytes (0%)
app.[hash].js.map 656.09 KB 656.09 KB 0 bytes (0%)
favicon-16x16.png 622 bytes 622 bytes 0 bytes (0%)
favicon-32x32.png 1.14 KB 1.14 KB 0 bytes (0%)
vendor.[hash].js 424.95 KB 424.95 KB 0 bytes (0%)
vendor.[hash].js.map 1.68 MB 1.68 MB 0 bytes (0%)
nusmods-logo.[hash].png 21.72 KB 21.72 KB 0 bytes (0%)
index.es.js 1.73 KB [deleted]
index.es.js.map 8.32 KB [deleted]
index.js 1.72 KB [deleted]
index.js.map 8.32 KB [deleted]
index.umd.js 1.89 KB [deleted]
index.umd.js.map 8.32 KB [deleted]
README.md 2.77 KB [deleted]
precache-manifest.[hash].js 1.47 KB 1.47 KB 0 bytes (0%)
service-worker.js 1.71 KB 1.71 KB 0 bytes (0%)

@mods-bot
Copy link

mods-bot commented Jul 15, 2018

Deploy preview for nusmods ready!

Built with commit c836229

https://deploy-preview-1049--nusmods.netlify.com

@ZhangYiJiang
Copy link
Member Author

I think this looks much better (although having a limit of NaN because we didn't specify the limit is kind of funny)

In merge check

screenshot from 2018-07-15 14-31-39

View details

screenshot from 2018-07-15 14-32-11

@li-kai
Copy link
Member

li-kai commented Jul 15, 2018

300kb sounds reasonable? Once we exceed it means we should code split.

@ZhangYiJiang
Copy link
Member Author

I don't feel like setting a limit. Code splitting wouldn't help with the size calculation since I'm grouping all JS file as one tracked "section" (see the changes to package.json). Unless we explicitly name split sections, there isn't a good way to track them (maybe we should set import names?) since the tracking is done via file names. Actually now I'm curious if the compare size against master function will work since our filenames change with every release.

@ZhangYiJiang ZhangYiJiang merged commit 0a85581 into master Jul 27, 2018
@ZhangYiJiang ZhangYiJiang deleted the integrate-bundlesize branch July 27, 2018 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants