Additional logging improvements and cleanup #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gbakeman
commented
Aug 8, 2022
gbakeman
commented
- Lots of code cleanup throughout the project, simplifying references and removing imports.
- Logger tweaks; max events stored in buffer is 4x increased
- Against my earlier quest for Object-Oriented Programming, I've moved the Logger object back into Globals.
- The Globals are now initialized in the App startup method rather than the Form's, this way they should be more "global".
- Tweaked the crash report dialog to be slightly more predictable and user-friendly (in case copy to clipboard fails)
- Fixed crash in Update_Gui due to missing variable
Thought I was disabling it for Release only...
- Moved Logger object and initialization back into Globals module. - Disabled system.diagnostics listeners in app.config after trying to figure out how to change log location. It looks like setting a FileLog location in app.config isn't supported. If we're going to upgrade logging anyways, it's best to get a third party library. - ApplicationEvents.vb now has a Startup subroutine for initializaing the Globals module and logging. - Cleaned up Report generation subroutine. User data dir is synchronized with the Globals module, and an Explorer window is opened to the destination after the crash report is generated. - More Logger changes. Base file name follows the ProgramName, the event buffer size has been quadrupled (and is now a property) - Prefs_Gui no longer directly controls Logging - this is handled back in WinNUT.vb. - Fixed crash in Update_Gui due to missing Logger variable, and cleaned up code. WinNUT.vb: - After loading parameters, trigger PrefsChanged to make sure everything is applied. Logging init is also handled elsewhere now. - More code cleanup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.