Attempting to finally solve data directory oddities #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trying to fix log files ending up in the C:\ directory. SetupAppDirectory is now private, and named GetAppDirectory. This is now strictly a function that tries to create the base directory and return it. It will also fallback to the temp directory if necessary, and hopefully log the error. The Globals method has also generally been rearranged and cleaned up with respect to logging and directories.
To vastly simplify the Init_Globals routine, I've moved some shortcut properties/other static information into the variable definitions area of the module. Also instantiate the Logger class right away so it's available to take calls ASAP.
Any path-related constants only represent the directory that the WinNUT-Client data container directory goes in. The WinNUT directory will be appended later on.
- Tried to use default date/time formats when possible (not sure it actually affects anything though) - Bolstered initialization routine for logging to provide better info and past events sitting in the buffer. - Broke out log line formatting into its own function - Return the data directory name back to what it was before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Judging from my Debugging output folder, it looks like generating the application's data directory has been broken since after November 11. Not quite sure what commit did it, but here's a summary of what's in this PR:
General reorganization of the
WinNUT_GlobalsModule.Logger improvements
Should close Log files still being saved in system root folder #61.