Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix combining @lazyLoad with paginated relations #1867

Merged
merged 2 commits into from
Jun 8, 2021
Merged

Fix combining @lazyLoad with paginated relations #1867

merged 2 commits into from
Jun 8, 2021

Conversation

hosmelq
Copy link
Contributor

@hosmelq hosmelq commented Jun 2, 2021 •
edited
Loading

  • Added or updated tests
  • Documented user facing changes
  • Updated CHANGELOG.md

Changes

Allow LengthAwarePaginator as a parameter in LazyLoadDirective directive.

Breaking changes

None.

@hosmelq hosmelq changed the title fix lazy load directive fix lazy load directive when used with a connection Jun 2, 2021
@spawnia spawnia added the bug An error within Lighthouse label Jun 8, 2021
@spawnia spawnia changed the title fix lazy load directive when used with a connection Fix combining @lazyLoad with paginated relations Jun 8, 2021
@spawnia spawnia merged commit 38b08e4 into nuwave:master Jun 8, 2021
@spawnia
Copy link
Collaborator

spawnia commented Jun 8, 2021

Nicely done and well tested, thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug An error within Lighthouse
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hosmelq @spawnia