Throw error if pagination amount <= 0 is requested #765
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue/Intent
Resolves #760
Changes
This prevents an issue where Laravel defaulted to the Model's
$perPage
amount when a userrequested a count of
0
. Thepaginate_max_amount
setting was ignored in this case.Now, if a client tries to request a paginated field with an amount of
<= 0
, they will be met with an error:To make this change easier and apply consistent behaviour to all paginated fields (
@paginate
and@hasMany
), i refactored some parts around how the pagination arguments are handled.Breaking changes
Nope