Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WEBUI-912: Improve contrast on breadcrumb items #1657

Merged
merged 1 commit into from
Nov 21, 2022
Merged

WEBUI-912: Improve contrast on breadcrumb items #1657

merged 1 commit into from
Nov 21, 2022

Conversation

poonamyadav252
Copy link
Contributor

No description provided.

@poonamyadav252 poonamyadav252 requested a review from a team as a code owner November 21, 2022 07:20
GuruprasadAnk1996
GuruprasadAnk1996 reviewed Nov 21, 2022
View reviewed changes
Copy link
Contributor

@GuruprasadAnk1996 GuruprasadAnk1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here changing the opacity will work, no need to add the color and it should be on line 103

@poonamyadav252 poonamyadav252 force-pushed the imp-WEBUI-912-improve-contrast-on-breadcrumb-items branch from 944dc17 to 52c4bd6 Compare November 21, 2022 09:31
@semisse
Copy link
Collaborator

semisse commented Nov 21, 2022

Was this change confirmed with design team?

swarnadipa-dev
swarnadipa-dev approved these changes Nov 21, 2022
View reviewed changes
Copy link
Contributor

@swarnadipa-dev swarnadipa-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@poonamyadav252 poonamyadav252 merged commit 07b3c08 into maintenance-3.0.x Nov 21, 2022
@poonamyadav252 poonamyadav252 deleted the imp-WEBUI-912-improve-contrast-on-breadcrumb-items branch November 21, 2022 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardsd richardsd richardsd approved these changes

@swarnadipa-dev swarnadipa-dev swarnadipa-dev approved these changes

@rajatgoel-gl rajatgoel-gl rajatgoel-gl approved these changes

@GuruprasadAnk1996 GuruprasadAnk1996 GuruprasadAnk1996 approved these changes

@Nishant0928 Nishant0928 Nishant0928 approved these changes

@Pranit-Sotre Pranit-Sotre Awaiting requested review from Pranit-Sotre Pranit-Sotre is a code owner automatically assigned from nuxeo/ui

@Nisha-QA Nisha-QA Awaiting requested review from Nisha-QA

@rakeshkumar1019 rakeshkumar1019 Awaiting requested review from rakeshkumar1019

@semisse semisse Awaiting requested review from semisse

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@poonamyadav252 @semisse @richardsd @swarnadipa-dev @rajatgoel-gl @GuruprasadAnk1996 @Nishant0928