feat(icon): make icons accessible #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manniL
force-pushed
the
feature-accessible-icons
branch
from
0b70cbf
to
c1cf1b7
Compare
|
Ping @pi0 |
|
Hey @manniL. Sorry for missing this PR. Actually, this would be a nice feature but it's somehow out of the PWA/icon's scope. I mean we can make this plugin to inject |
|
@pi0 No problem at all! Will update the PR with your suggestion as soon as I can! |
manniL
force-pushed
the
feature-accessible-icons
branch
from
c1cf1b7
to
c6c226e
Compare
|
@pi0 Updated! |
|
LGTM @manniL are tests passing on your side? |
|
@galvez Yup. Removed a forgotten |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, icons can be accessed through Vue.$icons (or custom property name).
Use case:
Sometimes you want to use smaller versions of your original logo on your page. Instead of adding another image to assets, you can now get URL and size directly through Vue.
Resolves #46