New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offline page assets #85

Merged
merged 3 commits into from Aug 25, 2018

Conversation

Projects
None yet
2 participants
@galvez
Collaborator

galvez commented Aug 24, 2018

I already tested this in my main test project, but can I have an extra pair of eyes here?

I'm using it like this:

      workbox: {
        offlinePage: '/offline/offline.html',
        offlinePageAssets: ['/offline/offline.png'],

I thought it was better to be able to specify offlinePage-specific assets rather than adding extra glob patterns to capture images in ~/assets.

@galvez galvez requested review from manniL and pi0 Aug 24, 2018

@codecov

This comment has been minimized.

codecov bot commented Aug 25, 2018

Codecov Report

Merging #85 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           develop    #85   +/-   ##
======================================
  Coverage      100%   100%           
======================================
  Files            1      1           
  Lines            1      1           
======================================
  Hits             1      1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef670b8...3e99108. Read the comment docs.

@pi0

pi0 approved these changes Aug 25, 2018

@pi0 pi0 merged commit 8bc4a3b into develop Aug 25, 2018

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing ef670b8...3e99108
Details
codecov/project 100% remains the same compared to ef670b8
Details

@manniL manniL deleted the offline-page-assets branch Sep 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment