Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: add support for nuxt 3/nuxt bridge #52

Merged
merged 17 commits into from
Jul 29, 2022
Merged

Conversation

ricardogobbosouza
Copy link
Collaborator

@ricardogobbosouza ricardogobbosouza commented Feb 11, 2022

This PR enables this module to work for Nuxt Bridge & Nuxt 3.

🔥 Notable changes

  • Uses @nuxt/module-builder to build module
  • Refactor structure using @nuxt/kit
  • Move modules options to rules property
  • Add option configPath to use configuration as file robots.config.ts
  • Disable module if exists robots.txt inside public directory

Resolves nuxt/framework#49

Copy link
Contributor

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this initiative! It looks great.

Key next step is to decide whether to generate robots.txt dynamically (see my comments about server middleware).

README.md Outdated Show resolved Hide resolved
src/module.ts Outdated Show resolved Hide resolved
@dargmuesli
Copy link
Contributor

@ricardogobbosouza you mentioned that reenabling the test suite is a TODO. Fyi, the issue you linked to that was closed yesterday :)

@dargmuesli
Copy link
Contributor

Hey @ricardogobbosouza, 3 months later I want to ask about the state of this PR nicely :) have a great day!

@damevin
Copy link

damevin commented Jul 21, 2022

Hello @ricardogobbosouza ! Have you news about that work ? :)

@ricardogobbosouza
Copy link
Collaborator Author

I'm working on this module. I should prerelease today

@damevin
Copy link

damevin commented Jul 28, 2022

Hey @ricardogobbosouza hope you're well ! :)
Sorry to insit with that, did you need any help for release the support for nuxt 3 ?
Have a good day

@ricardogobbosouza
Copy link
Collaborator Author

Hi @damevin
Waiting unjs/knitwork#9

@ricardogobbosouza ricardogobbosouza merged commit d950072 into main Jul 29, 2022
@ricardogobbosouza ricardogobbosouza deleted the feat/nuxt3-bridge branch July 29, 2022 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants