Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid depending on node process #16

Merged
merged 1 commit into from
May 17, 2021
Merged

fix: avoid depending on node process #16

merged 1 commit into from
May 17, 2021

Conversation

pantajoe
Copy link

@pantajoe pantajoe commented May 7, 2021 •
edited
Loading

In order to use this package in an environment where node internals, such as (and very specifically) process is not available,
this PR introduces a check whether the node.js internal process is actually defined.

@pantajoe pantajoe changed the title Remove Node Dependency fix: Remove Node Dependency May 7, 2021
@pantajoe pantajoe mentioned this pull request May 7, 2021
Closed
@galvez
Copy link

galvez commented May 8, 2021

cc @pi0

@pi0 pi0 changed the title fix: Remove Node Dependency fix: avoid depending on node process May 17, 2021
pi0
pi0 approved these changes May 17, 2021
View reviewed changes
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pi0 pi0 merged commit a3231b0 into nuxt-contrib:main May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pantajoe @galvez @pi0