Feat: cookie storage #256
Closed
Feat: cookie storage #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…mode into feat/sync-cookie
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
|
still working on merge conflicts and other small problems, please hold |
|
that should have the SSR working, and it will look similar to the demo page (whether its supposed to looks broken I'm unsure, but I made it look like the demo page). Once again, I must thank Hossein-Mirazimi and manniL for the original code for all of their great work |
|
@juls0730 How is the progress of this pr now, thank you！ |
|
Hey @wkl007 i believe it was working when I closed it, but I can check again and confirm |
|
update: there is absolutely no way it was working when I closed the PR because I'm pretty confident it was not adding the class server-side, it is now doing that on the latest commit |
|
@juls0730 Thank you very much for your reply. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build off of #221 and make SSR better with cookie storage. The original PR seems a bit dead, and I want to get this past the finish line. I'm unsure if manniL or Hossein-Mirazimi forgot about the PR or something, but I'm trying to just get it merged lol