Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pnpm support without --shamefully-hoist #2506

Closed
2 of 4 tasks
cexbrayat opened this issue Oct 18, 2023 · 3 comments
Closed
2 of 4 tasks

pnpm support without --shamefully-hoist #2506

cexbrayat opened this issue Oct 18, 2023 · 3 comments
Labels
deps ❗ p4-important Priority 4: bugs that violate documented behavior, or significantly impact perf v8

Comments

@cexbrayat
Copy link

Describe the feature

Nuxt itself now supports pnpm without forcing the usage of --shamefully-hoist, see nuxt/nuxt#14146

But when adding @nuxtjs/i18n@next with:

pnpm add @nuxtjs/i18n@next --save-dev

then a minimal application does not build because of missing dependencies.

We currently have to at least add:

    "@intlify/core-base": "^9.5.0",
    "@intlify/message-compiler": "^9.5.0",
    "@intlify/shared": "^9.5.0",
    "@intlify/vue-i18n-bridge": "^1.0.1",
    "@intlify/vue-router-bridge": "^1.0.1",
    "@nuxtjs/i18n": "8.0.0-rc.5",
    "is-https": "^4.0.0",
    "js-cookie": "^3.0.5",
    "vue-i18n": "^9.5.0",
    "vue-i18n-routing": "^1.1.1"

to make a minimal application build.

See this minimal repro on stackblitz https://stackblitz.com/edit/nuxt-starter-m6l8tv?file=nuxt.config.ts,package.json

It would be great if this module supporte pnpm out the box, without needing to add all these dependencies explicitely.

Additional information

  • Would you be willing to help implement this feature?
  • Could this feature be implemented as a module?

Final checks

@kazupon kazupon added v8 ❗ p4-important Priority 4: bugs that violate documented behavior, or significantly impact perf deps and removed pending triage labels Oct 19, 2023 — with Volta.net
Copy link
Collaborator

kazupon commented Oct 19, 2023

Thank you for your reporting!
This issue and related issues are working on right now.
#2503
#2504
I believe those are fixed, when that will be finished.

@BobbieGoede
Copy link
Collaborator

It seems to mostly work without installing all the deps, for some reason is-https still needs to be installed explicitely. 🤔

Changed your reproduction to demontrate here

@BobbieGoede
Copy link
Collaborator

This should work now on the latest edge channel!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deps ❗ p4-important Priority 4: bugs that violate documented behavior, or significantly impact perf v8
Projects
None yet
Development

No branches or pull requests

3 participants