fix: use nested optimizeDeps to resolve properly

nuxt-modules · Mar 10, 2024 · 1dab8e4 · 1dab8e4
1 parent 3e810a1
commit 1dab8e4
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 33 deletions.
diff --git a/docs/content/1.getting-started/4.visual-editing.md b/docs/content/1.getting-started/4.visual-editing.md
@@ -10,14 +10,6 @@
 Installing `@sanity/client` is required for visual editing. The `minimal` client must not be enabled.
 ::
 
-::alert{type=warning}
-If you are using `pnpm` with `shamefully-hoist=false` (which is enabled by default for pnpm), you will also need to install the following dependencies:
-
-```bash
-pnpm i -D async-cache-dedupe debug parse-headers react react-dom react-is
-```
-::
-
 ## Configuration
 
 You can configure visual editing via the `sanity.visualEditing` key in your Nuxt config. The following options are available:

diff --git a/playground/package.json b/playground/package.json
@@ -8,13 +8,7 @@
   "dependencies": {
     "@nuxtjs/sanity": "latest",
     "@sanity/client": "latest",
-    "async-cache-dedupe": "latest",
-    "debug": "latest",
     "nuxt": "3.10.3",
-    "parse-headers": "latest",
-    "react": "latest",
-    "react-dom": "latest",
-    "react-is": "latest",
     "vue": "latest",
     "vue-router": "latest"
   }

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/src/module.ts b/src/module.ts
@@ -290,8 +290,22 @@ export default defineNuxtModule<SanityModuleOptions>({
 
     if (options.visualEditing) {
       // Optimise dependencies of visual editing
+      nuxt.options.build.transpile.push('async-cache-dedupe')
+      nuxt.options.vite.resolve = defu(nuxt.options.vite.resolve, {
+        dedupe: ['@sanity/client'],
+      })
       nuxt.options.vite.optimizeDeps = defu(nuxt.options.vite.optimizeDeps, {
-        include: ['async-cache-dedupe', 'react/jsx-runtime', 'parse-headers', 'debug', 'react-dom/client', 'react-is', 'react', 'react-dom'],
+        include: [
+          '@nuxtjs/sanity > @sanity/core-loader > async-cache-dedupe',
+          '@nuxtjs/sanity > @sanity/visual-editing > @sanity/visual-editing > react-is',
+          '@nuxtjs/sanity > @sanity/visual-editing > react',
+          '@nuxtjs/sanity > @sanity/visual-editing > react/jsx-runtime',
+          '@nuxtjs/sanity > @sanity/visual-editing > react-dom',
+          '@nuxtjs/sanity > @sanity/visual-editing > react-dom/client',
+          '@sanity/client > get-it > debug',
+          '@sanity/client > get-it > parse-headers',
+          '@sanity/client',
+        ],
       })
       // Add auto-imports for visual editing
       if (isNuxt3()) {