fix(i18n): don't transform links with protocol

Fixes #262
nuxt-modules · May 6, 2024 · 0949698 · 0949698
1 parent 8494928
commit 0949698
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 3 deletions.
diff --git a/src/runtime/nitro/sitemap/urlset/i18n.ts b/src/runtime/nitro/sitemap/urlset/i18n.ts
@@ -1,4 +1,4 @@
-import { joinURL, parseURL, withHttps, withLeadingSlash } from 'ufo'
+import { hasProtocol, joinURL, parseURL, withHttps, withLeadingSlash } from 'ufo'
 import type {
   AlternativeEntry,
   ModuleRuntimeConfig,
@@ -14,15 +14,17 @@ export function normaliseI18nSources(sources: SitemapSourceResolved[], { autoI18
       const urls = (s.urls || []).map((_url) => {
         const url = typeof _url === 'string' ? { loc: _url } : _url
         url.loc = url.loc || url.url!
-        url.loc = withLeadingSlash(url.loc)
+        if (!hasProtocol(url.loc, { acceptRelative: true }))
+          url.loc = withLeadingSlash(url.loc)
+
         return url
       })
       s.urls = urls.map((url) => {
         // only if the url wasn't already configured, excludes page, etc
         if (url._sitemap || url._i18nTransform)
           return url
         // if the url starts with a prefix, we should automatically bundle it to the correct sitemap using _sitemap
-        if (url.loc) {
+        if (url.loc && !hasProtocol(url.loc, { acceptRelative: true })) {
           const match = splitForLocales(url.loc, autoI18n.locales.map(l => l.code))
           const localeCode = match[0] || autoI18n.defaultLocale
           const pathWithoutPrefix = match[1]

diff --git a/test/fixtures/i18n/server/routes/i18n-urls.ts b/test/fixtures/i18n/server/routes/i18n-urls.ts
@@ -15,5 +15,7 @@ export default defineSitemapEventHandler(() => {
     {
       loc: 'english-url', // issue with en being picked up as the locale
     },
+    // absolute URL issue
+    { loc: 'https://www.somedomain.com/abc/def' },
   ]
 })
diff --git a/test/integration/i18n/dynamic-urls.test.ts b/test/integration/i18n/dynamic-urls.test.ts
@@ -51,6 +51,9 @@ describe('i18n dynamic urls', () => {
               <xhtml:link rel="alternate" hreflang="fr-FR" href="https://nuxtseo.com/fr/__sitemap/url" />
               <xhtml:link rel="alternate" hreflang="es-ES" href="https://nuxtseo.com/es/__sitemap/url" />
           </url>
+          <url>
+              <loc>https://www.somedomain.com/abc/def</loc>
+          </url>
           <url>
               <loc>https://nuxtseo.com/en/dynamic/foo</loc>
               <xhtml:link rel="alternate" href="https://nuxtseo.com/en/dynamic/foo" hreflang="x-default" />