Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(.starters): import alpine-starter into .starters/default #135

Merged
merged 6 commits into from May 11, 2023

Conversation

Tahul
Copy link
Contributor

@Tahul Tahul commented May 10, 2023

Resolves https://github.com/nuxtlabs/studio-app/issues/821 for Alpine

You can boot the default starter using npm run play:starter.

@codesandbox
Copy link

codesandbox bot commented May 10, 2023

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@vercel
Copy link

vercel bot commented May 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
alpine ❌ Failed (Inspect) May 11, 2023 9:06am

@Tahul Tahul requested review from Atinux and larbish May 10, 2023 15:20
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@Tahul
Copy link
Contributor Author

Tahul commented May 10, 2023

@Atinux ; I think for Alpine the .docs and .starters/default directory are the same.

The only issue that remains is that if we drop .docs in favor of .starters/default, we won't be able to properly run the theme with the local version of Alpine without the need to overwrite some code everytime we want to boot with such setup.

What should I do for this?

I think I can drop .docs and add guidelines for contributing in the readme, or maybe you know a solution?

@Tahul
Copy link
Contributor Author

Tahul commented May 10, 2023

Maybe I could also work a bit on backend side that makes the copy of our starters and support overwriting the package.json at that time. 🤷

@Tahul
Copy link
Contributor Author

Tahul commented May 10, 2023

(The scripts rewrite obviously breaks the deployment, I guess doing deployments from Studio itself is the point of these PRs anyways)

Copy link
Contributor

larbish commented May 11, 2023

What is the issue with the deployment ? What is the difference with https://github.com/Atinux/content-wind (it used the .demo folder in production already) ?

@Atinux
Copy link
Contributor

Atinux commented May 11, 2023

@Atinux ; I think for Alpine the .docs and .starters/default directory are the same.

The only issue that remains is that if we drop .docs in favor of .starters/default, we won't be able to properly run the theme with the local version of Alpine without the need to overwrite some code everytime we want to boot with such setup.

What should I do for this?

I think I can drop .docs and add guidelines for contributing in the readme, or maybe you know a solution?

Actually it works well with content-wind thanks to pnpm workspace linking automatically in development so we should not have to change anything normally

@Atinux
Copy link
Contributor

Atinux commented May 11, 2023

So .starters/default is the new .docs

@nuxt-studio
Copy link

nuxt-studio bot commented May 11, 2023

Live Preview ready!

Name Edit Preview Latest Commit
Alpine Edit on Studio ↗︎ View Live Preview cdd12b6

@Tahul Tahul merged commit 8a64f9d into main May 11, 2023
0 of 2 checks passed
@Tahul Tahul deleted the feat/starters-dir branch May 11, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants