Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

analyze should not prerender routes when specified via routeRules #328

Open
manniL opened this issue Jan 16, 2024 · 1 comment
Open

analyze should not prerender routes when specified via routeRules #328

manniL opened this issue Jan 16, 2024 · 1 comment
Labels
command:analyze enhancement New feature or request

Comments

@manniL
Copy link
Member

manniL commented Jan 16, 2024

When analyzing a site via the analyze command, no prerendering should happen, even if routeRules: { '/**': { prerender: true } } or similar is set.
@manniL manniL added the enhancement New feature or request label Jan 16, 2024
@pi0
Copy link
Member

pi0 commented Jan 16, 2024 •
edited
Loading

There is only one tricky case that some modules use prerender to emit assets that count in bundle size. But I think we can at least move --prerender behind a flag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
command:analyze enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@manniL @pi0