Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(formatting): fix formatting when multiple back-quotes #44

Merged
merged 1 commit into from
Mar 19, 2019

Conversation

atinux
Copy link
Member

@atinux atinux commented Mar 19, 2019

Before:
Screenshot 2019-03-19 at 17 53 12

After:
Screenshot 2019-03-19 at 17 52 24

@atinux atinux requested a review from pi0 March 19, 2019 16:53
@manniL
Copy link
Member

manniL commented Mar 19, 2019

I think we slowly need a CI and a test suite 😋

@pi0
Copy link
Member

pi0 commented Mar 19, 2019

@manniL It was not due to laziness to not have a CI. Tets can't generally cover such problems. They can just prevent unwanted breaking changes or regressions.

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@pi0 pi0 changed the title fix(formatting): Fix formatting when multiple backquotes fix(formatting): fix formatting when multiple back-quotes Mar 19, 2019
@pi0 pi0 merged commit 669a12e into master Mar 19, 2019
@pi0 pi0 deleted the fix/backquotes branch March 19, 2019 17:17
@manniL
Copy link
Member

manniL commented Mar 19, 2019

@pi0 Never wanted to imply that!
You are right, this bug wouldn't have been caught by CI either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants