Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): fix typing error #409

Merged
merged 1 commit into from
Aug 25, 2020
Merged

fix(types): fix typing error #409

merged 1 commit into from
Aug 25, 2020

Conversation

nogic1008
Copy link
Contributor

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Since PR #327 was merged, tsc throws the following error:

node_modules/@nuxt/content/types/index.d.ts:6:45 - error TS2307: Cannot find module 'node-csvtojson/v2/Parameters' or its corresponding type declarations.

6 import { CSVParseParam as csvOptions } from "node-csvtojson/v2/Parameters";
                                              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Found 1 error.

Probably node-csvtojson is a typo of csvtojson.

And, PR #327 forces you to add an empty content property in configuration file.

This PR fixes module name typo, and set content property as optional.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes (if not applicable, please state why)

No need tests because this PR only changes typing.

@benjamincanac
Copy link
Member

Nice catch 🙂

@benjamincanac benjamincanac merged commit 23a84f8 into nuxt:dev Aug 25, 2020
@nogic1008 nogic1008 deleted the patch-1 branch August 25, 2020 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants