Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle router base #78

Merged
merged 4 commits into from
Jun 8, 2020
Merged

Handle router base #78

merged 4 commits into from
Jun 8, 2020

Conversation

benjamincanac
Copy link
Member

No description provided.

@benjamincanac benjamincanac linked an issue Jun 1, 2020 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Jun 1, 2020

Codecov Report

Merging #78 into master will increase coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #78      +/-   ##
==========================================
+ Coverage   93.50%   93.60%   +0.09%     
==========================================
  Files          13       13              
  Lines         416      422       +6     
  Branches       79       81       +2     
==========================================
+ Hits          389      395       +6     
  Misses         24       24              
  Partials        3        3              
Impacted Files Coverage Δ
lib/index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93b7978...a08ef87. Read the comment docs.

@benjamincanac benjamincanac requested a review from Atinux June 2, 2020 15:04
@benjamincanac benjamincanac marked this pull request as ready for review June 2, 2020 15:35
lib/templates/plugin.client.js Outdated Show resolved Hide resolved
@benjamincanac benjamincanac requested a review from Atinux June 3, 2020 11:03
@benjamincanac benjamincanac merged commit 6cdeed1 into master Jun 8, 2020
@benjamincanac benjamincanac deleted the fix/router-base branch June 8, 2020 18:07
pi0 pushed a commit that referenced this pull request Feb 8, 2022
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Router.base ignored when fetching content
3 participants