Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lint): disable eslint nuxt.config.js extend line #491

Merged
merged 3 commits into from May 18, 2020
Merged

fix(lint): disable eslint nuxt.config.js extend line #491

merged 3 commits into from May 18, 2020

Conversation

zalog
Copy link
Contributor

@zalog zalog commented Apr 21, 2020

config and ctx are not used, I think it would be ok if we disable eslint on this line.

clarkdo
clarkdo reviewed Apr 21, 2020
View reviewed changes
Copy link
Member

@clarkdo clarkdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can comment extend as we already provide clear comment You can extend webpack config here, so user can uncomment it as their needs.

@clarkdo clarkdo changed the title style: disable eslint line fix(lint): disable eslint nuxt.config.js extend line Apr 21, 2020
@clarkdo clarkdo requested a review from a team April 21, 2020 20:46
@Atinux
Copy link
Member

Atinux commented Apr 22, 2020

I think we can remove extends and add a line in the comments block to https://nuxtjs.org/api/configuration-build/

@zalog
Copy link
Contributor Author

zalog commented Apr 22, 2020

Tnks for your time guys.
Ok @Atinux , I'll come back with a commit soon.

clarkdo
clarkdo reviewed Apr 22, 2020
View reviewed changes
Copy link
Member

@clarkdo clarkdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please fix the test by updating snapshot ?

@zalog
Copy link
Contributor Author

zalog commented Apr 22, 2020

Sorry @clarkdo I'm not sure how can I do that, can you be more specific please? :)

@NickBolles
Copy link

NickBolles commented Apr 23, 2020 •
edited

this also fixed as part of #449, I just added the _ prefix, which is pretty standard for an unused variable

@Atinux Atinux merged commit a7d3142 into nuxt:master May 18, 2020
@zalog zalog deleted the patch-1 branch May 18, 2020 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clarkdo clarkdo clarkdo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zalog @Atinux @NickBolles @clarkdo