New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Cannot find module 'nuxt-edge' #91

Merged
merged 2 commits into from Sep 23, 2018

Conversation

Projects
None yet
5 participants
@remarks
Copy link
Contributor

remarks commented Sep 22, 2018

With Nuxt 2.0's release, the nuxt-edge dependency is invalid. Changed server template imports to reflect that. Taking into account previous PRs regarding this issue, I've omitted changes from those.

@aldarund

This comment has been minimized.

Copy link
Member

aldarund commented Sep 22, 2018

There also references to nuxt-edge in
template/frameworks/micro/server/micro.config.js
template/server/index-koa.js

@remarks

This comment has been minimized.

Copy link
Contributor Author

remarks commented Sep 22, 2018

@aldarund updated this!

@Codefa

This comment has been minimized.

Copy link
Contributor

Codefa commented Sep 23, 2018

to fix this issue install nuxt-edge,

npm i nuxt-edge

Thank you

@remarks

This comment has been minimized.

Copy link
Contributor Author

remarks commented Sep 23, 2018

@Codefa from what I understand nuxt-edge is only for bleeding edge features, not for stable releases. So I think it’s smarter to use base nuxt as the main dependency. Unless another expert can chime in on this.

@robcresswell

This comment has been minimized.

Copy link

robcresswell commented Sep 23, 2018

Duplicate of #87, isn't it? Same purpose at least

@robcresswell

This comment has been minimized.

Copy link

robcresswell commented Sep 23, 2018

My understanding is that nuxt edge was just the testing branch for people eager to try 2.x

Now that it's live, this should really point at nuxt

@Codefa

This comment has been minimized.

Copy link
Contributor

Codefa commented Sep 23, 2018

My understanding is that nuxt edge was just the testing branch for people eager to try 2.x

Now that it's live, this should really point at nuxt

yeah ofcourse nuxt-edge is the teting one like a beta it clearly written in their release notes

We now use Webpack 4. We announced 2.x and started publishing latest changes as nuxt-edge package at March. But we wanted to make sure that most of the plugins were updated and stable before releasing a stable version of Nuxt.js

they released 2.0 but didn't updated the master of this repo
chopin brothers will update it .

@Atinux

This comment has been minimized.

Copy link
Member

Atinux commented Sep 23, 2018

Indeed, these nuxt-edge import no longer need to be used, thank you @remarks, will publish new create-nuxt-app version quickly

@Atinux Atinux merged commit 92c0972 into nuxt:master Sep 23, 2018

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

mikejavier added a commit to mikejavier/create-nuxt-app that referenced this pull request Oct 12, 2018

Update fork (#1)
* Update nuxt-buefy version (nuxt#85)

* Update nuxt-buefy version

Details about the problem of being with the outdated version can be found in this [issue](buefy/nuxt-buefy#23)

* Update nuxt-buefy version to 0.2.1

*  feat: upgrade nuxt to edge (2.0) (nuxt#79)

* feat: upgrade nuxt to edge (2.0)

* test: fix failures

* Update _package.json

* update snapshots

* 2.0.0

* Update Vuetify to latest version (nuxt#93)

* fix: tailwind dependency (nuxt#92)

* fix: tailwind dependency

* improvement: add sample at-rule styles

* fix: Cannot find module 'nuxt-edge' (nuxt#91)

* fix: Cannot find module 'nuxt-edge'

* fix: nuxt dependency for micro+koa

* fix: Cannot find module 'nuxt-edge' (nuxt#87)

* fix: Cannot find module 'nuxt-edge'

* fix: all nuxt-edge require nuxt now

* fix miss nuxt-edge module error (nuxt#88)

* 2.0.1

* update vuetify template (nuxt#96)

* Add prettier configuration as option (nuxt#94)

* option for using prettier

* fix eslint filter

* update gitignore with more rules for node (nuxt#95)

* 2.1.0

* Fix linting thrown from default template when enabling prettier option, container centering when enabling tailwind option (nuxt#98)

* fix default linting errors when enabling prettier option
* fix centering issue for tailwind option, fix vuetify styles for prettier option

* 2.1.1

* Fixing additional prettier errors (nuxt#100)

* fix default linting errors when enabling prettier option

* fix centering issue for tailwind option, fix vuetify styles for prettier option

* fix additional prettier errors for tailwind, buefy and vuetify

* fixes all prettier errors

* update ava snapshot, add command for creating a snapshot

* remove eslint-disable for vue/no-v-html parts

* Update package.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment