Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Eye Dropper command #530

Merged
merged 2 commits into from
Dec 7, 2023
Merged

feat: add Eye Dropper command #530

merged 2 commits into from
Dec 7, 2023

Conversation

arashsheyda
Copy link
Member

Adds eye dropper functionality to commands, this can be useful for anyone working on the UI to quickly identify and replicate specific colors within the application.

Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9508c5e
Status: ✅  Deploy successful!
Preview URL: https://51bb62c2.nuxt-devtools.pages.dev
Branch Preview URL: https://feat-eye-dropper.nuxt-devtools.pages.dev

View logs

@Atinux Atinux requested a review from antfu December 6, 2023 18:27
@Atinux
Copy link
Member

Atinux commented Dec 6, 2023

Would love to see a video about it!

@arashsheyda
Copy link
Member Author

@Atinux sure!

should we make it close the devtools window when eye dropper is selected?

Screen.Recording.2023-12-06.at.3.18.23.PM.mov

@Atinux
Copy link
Member

Atinux commented Dec 7, 2023

Damn I love it! I let @antfu confirm about it for implementation!

@antfu
Copy link
Member

antfu commented Dec 7, 2023

should we make it close the devtools window when eye dropper is selected?

That would be great I think. We could reuse the logic of component inspector

@antfu antfu merged commit 25584b9 into main Dec 7, 2023
1 of 2 checks passed
@antfu antfu deleted the feat/eye-dropper branch December 7, 2023 18:57
@antfu
Copy link
Member

antfu commented Dec 7, 2023

Let's have it for now, and we could improve it later

@arashsheyda
Copy link
Member Author

Okay, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants