Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: import server utils from #imports #249

Merged
merged 4 commits into from
Sep 3, 2024
Merged

fix: import server utils from #imports #249

merged 4 commits into from
Sep 3, 2024

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Sep 3, 2024

Resolves #204 (tested against reproduction in #204 (comment)).

When having multiple versions of nitropack installed (reproduction above has one in the playground and one in top level) for some reason rollup keeps nitropack/runtime as an external although it shouldn't be. this needs more upstream investigation later)

Using #imports seems to fix the issue as it aliases to the explicit path.

@antfu antfu changed the title fix: import server utils from `#imports fix: import server utils from #imports Sep 3, 2024
@antfu antfu merged commit 76b9ec4 into main Sep 3, 2024
1 check passed
@antfu antfu deleted the fix/nitro-import branch September 3, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package import specifier "#internal/nitro/virtual/app-config" is not defined
2 participants