Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow full usage of $img in plugins #284

Merged
merged 1 commit into from
May 19, 2021

Conversation

danielroe
Copy link
Member

This PR should allow image maps generated via programmatic usage of $img in plugins to be accessed dynamically within the page. (Without this PR, this would work on hard-reload but not on client-side navigation as it wouldn't be included in payload.)

context: #258

@danielroe danielroe requested a review from pi0 May 19, 2021 14:00
@codecov-commenter
Copy link

codecov-commenter commented May 19, 2021

Codecov Report

Merging #284 (69ec93b) into main (4ad029c) will increase coverage by 0.10%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #284      +/-   ##
==========================================
+ Coverage   56.95%   57.06%   +0.10%     
==========================================
  Files          23       23              
  Lines         525      524       -1     
  Branches      131      155      +24     
==========================================
  Hits          299      299              
+ Misses        226      225       -1     
Impacted Files Coverage Δ
src/runtime/image.ts 69.81% <0.00%> (+0.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ad029c...69ec93b. Read the comment docs.

@pi0 pi0 merged commit b80f791 into main May 19, 2021
@pi0 pi0 deleted the fix/allow-full-img-usage-in-plugins branch May 19, 2021 15:14
procrates pushed a commit to procrates/nuxt-image that referenced this pull request Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants