Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: strapi provider #406

Merged
merged 12 commits into from
Feb 17, 2022
Merged

feat: strapi provider #406

merged 12 commits into from
Feb 17, 2022

Conversation

roberthgnz
Copy link
Contributor

No description provided.

src/runtime/providers/strapi.ts Outdated Show resolved Hide resolved
src/runtime/providers/strapi.ts Outdated Show resolved Hide resolved
@pi0
Copy link
Member

pi0 commented Oct 8, 2021

Hi @eliutgon and thanks for the feature! Do you mind adding basic docs to providers and also mention about only breakpoint modifier is possible?

@roberthgnz
Copy link
Contributor Author

Hi @eliutgon and thanks for the feature! Do you mind adding basic docs to providers and also mention about only breakpoint modifier is possible?

Hi. sure, I will get on it.

src/runtime/providers/strapi.ts Outdated Show resolved Hide resolved
@pi0 pi0 changed the title feat: allow strapi uploads using the local provider feat: strapi provider Jan 13, 2022
@pi0 pi0 added the provider label Jan 13, 2022
@pi0
Copy link
Member

pi0 commented Feb 17, 2022

Sorry for the late merge. Implementation seems nice but strapi provider is different from others as it does not actually provide any means to resize or optimize images. Let's have it as is for now!

@codecov-commenter
Copy link

Codecov Report

Merging #406 (95b759c) into main (61bcb90) will decrease coverage by 59.11%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #406       +/-   ##
==========================================
- Coverage   59.11%   0.00%   -59.12%     
==========================================
  Files          29      28        -1     
  Lines         658     587       -71     
  Branches      208     188       -20     
==========================================
- Hits          389       0      -389     
- Misses        263     585      +322     
+ Partials        6       2        -4     
Impacted Files Coverage Δ
src/provider.ts 0.00% <ø> (-74.29%) ⬇️
src/runtime/providers/strapi.ts 0.00% <0.00%> (ø)
src/runtime/providers/ipx.ts 0.00% <0.00%> (-100.00%) ⬇️
src/runtime/providers/glide.ts 0.00% <0.00%> (-100.00%) ⬇️
src/runtime/providers/imgix.ts 0.00% <0.00%> (-100.00%) ⬇️
src/runtime/providers/fastly.ts 0.00% <0.00%> (-100.00%) ⬇️
src/runtime/providers/static.ts 0.00% <0.00%> (-100.00%) ⬇️
src/runtime/providers/unsplash.ts 0.00% <0.00%> (-100.00%) ⬇️
src/runtime/providers/contentful.ts 0.00% <0.00%> (-100.00%) ⬇️
src/runtime/providers/imageengine.ts 0.00% <0.00%> (-100.00%) ⬇️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61bcb90...95b759c. Read the comment docs.

@pi0 pi0 merged commit 8245c22 into nuxt:main Feb 17, 2022
procrates pushed a commit to procrates/nuxt-image that referenced this pull request Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants