Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add imgAttrs property to nuxt-picture #445

Merged
merged 3 commits into from
Jan 13, 2022

Conversation

codeflorist
Copy link
Contributor

@codeflorist codeflorist commented Oct 22, 2021

Currently there is no way to add any additional attributes (e.g. id, class, style, etc.) to the img element inside the nuxt-picture component.

This PR adds a imgAttrs property to nuxt-picture which takes an object, which can include any attributes one might like to add to the img element.

Fixes #317, Fixes #288, Fixes #449 and possibly #320

@codeflorist codeflorist changed the title feat: add imgAttrs property to nuxt-image feat: add imgAttrs property to nuxt-picture Oct 22, 2021
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2022

Codecov Report

Merging #445 (25bbbba) into main (512a54a) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #445   +/-   ##
=======================================
  Coverage   59.62%   59.62%           
=======================================
  Files          28       28           
  Lines         634      634           
  Branches      198      198           
=======================================
  Hits          378      378           
  Misses        256      256           
Impacted Files Coverage Δ
src/runtime/components/nuxt-picture.vue 77.50% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 512a54a...25bbbba. Read the comment docs.

@pi0 pi0 merged commit 448d9ef into nuxt:main Jan 13, 2022
procrates pushed a commit to procrates/nuxt-image that referenced this pull request Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants