Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ipx): allow overriding baseURL regardless of router base #484

Merged
merged 4 commits into from
Jun 21, 2022

Conversation

jeanmatthieud
Copy link
Contributor

@jeanmatthieud jeanmatthieud commented Feb 4, 2022

#483

Removing this non existing context variable use allows the proper configuration of the baseURL variable, and, at the same time, the use of an external IPX server.

@pi0 pi0 changed the title [FIX] Not existing context variable use removed #483 fix: remove not existing context variable Jun 20, 2022
@pi0 pi0 changed the title fix: remove not existing context variable fix(ipx): allow overriding baseURL regardless of router base Jun 21, 2022
@pi0
Copy link
Member

pi0 commented Jun 21, 2022

Thanks. I've fixed types and made modification to still be able completely override baseURL still respect router base when generating default _ipx endpoint.

@pi0 pi0 merged commit 2720956 into nuxt:main Jun 21, 2022
@jeanmatthieud jeanmatthieud deleted the external-ipx branch June 21, 2022 15:33
procrates pushed a commit to procrates/nuxt-image that referenced this pull request Feb 21, 2023
)

Co-authored-by: Pooya Parsa <pyapar@gmail.com>
@chrisspiegl
Copy link
Contributor

I just tried this out and first thought I could not use baseURL with the IPX and thus use an external IPX server because the baseURL seems to not be included in the typescript type of IPXOptions?

Xnapper-2023-02-28-18 54 27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants