Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: layer0 provider #501

Merged
merged 12 commits into from
Jun 21, 2022
Merged

feat: layer0 provider #501

merged 12 commits into from
Jun 21, 2022

Conversation

treboryx
Copy link
Contributor

resolves #498

Baroshem
Baroshem reviewed Mar 30, 2022
View reviewed changes
Copy link
Contributor

@Baroshem Baroshem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey!

Thanks for this feature! Before Pio reviews it, could you please recheck your linter configuration? I think that majority of the changes are caused by the lint command with different params.

@treboryx
Copy link
Contributor Author

Hey!

Thanks for this feature! Before Pio reviews it, could you please recheck your linter configuration? I think that majority of the changes are caused by the lint command with different params.

Hi!

Doesn't the lint command use local config? My editor's formatting is quite different so I made sure to run the lint command.

@Baroshem
Copy link
Contributor

Hey!
Thanks for this feature! Before Pio reviews it, could you please recheck your linter configuration? I think that majority of the changes are caused by the lint command with different params.

Hi!

Doesn't the lint command use local config? My editor's formatting is quite different so I made sure to run the lint command.

Hmm, that is strange then. Ok, let's wait for Pio, maybe he will have an answer for that :)

@pi0 pi0 changed the title feat: Layer0 support feat: layer0 provider Jun 20, 2022
@pi0 pi0 added the provider label Jun 20, 2022
pi0
pi0 approved these changes Jun 21, 2022
View reviewed changes
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks ❤️

@pi0 pi0 merged commit 5de4eb6 into nuxt:main Jun 21, 2022
procrates pushed a commit to procrates/nuxt-image that referenced this pull request Feb 21, 2023
@treboryx @pi0
feat: layer0 provider (nuxt#501)
5ce1ce0 
Co-authored-by: Pooya Parsa <pyapar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Baroshem Baroshem Baroshem left review comments

@pi0 pi0 pi0 approved these changes

Assignees
No one assigned
Labels
provider
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Layer0 support
3 participants
@treboryx @Baroshem @pi0