Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add twoslash support #1486

Merged
merged 16 commits into from Feb 16, 2024
Merged

feat: add twoslash support #1486

merged 16 commits into from Feb 16, 2024

Conversation

antfu
Copy link
Member

@antfu antfu commented Jan 25, 2024

It verifies nuxt-modules/mdc#129 works well with minimal changes, and a custom twoslash integration is working on it.

Screenshot 2024-02-07 at 16 43 52

TODO:

  • Extract the local twoslash layer into a module
  • Improve twoslash styles
  • Make Twoslash only run on prerender time and cache the LSP result for rendering
  • Remove patch and bump deps once mdc and content did the release

Copy link

nuxt-studio bot commented Jan 25, 2024

Live Preview ready!

Name Edit Preview Latest Commit
nuxt.com Edit on Studio ↗︎ View Live Preview 8328780

@antfu antfu changed the title feat: try mdc.config.js, and twoslash feat: add twoslash support Feb 13, 2024
@antfu
Copy link
Member Author

antfu commented Feb 16, 2024

@antfu antfu requested a review from Atinux February 16, 2024 11:10
@Atinux Atinux merged commit 5bff8fe into main Feb 16, 2024
3 checks passed
@Atinux Atinux deleted the feat/mdc-config branch February 16, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants