-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(types): build.html.minify
can be false
#8835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harlan-zw
changed the title
Chore/update minify type
chore(types): add false type to html minify
Feb 16, 2021
danielroe
approved these changes
Feb 16, 2021
pi0
changed the title
chore(types): add false type to html minify
fix(types): Feb 16, 2021
build.html.minify
can be false
Thanks! |
Merged
This was referenced Mar 10, 2021
This was referenced Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Types
Description
The
build.html.minify
option isn't typed correctly.It's passed to:
html-webpack-plugin
which allows for a boolean option OR an object, see: https://github.com/jantimon/html-webpack-plugin#minificationBecause it's also used in the generate code, if it was typed to be able to use
'auto'
ortrue
it may cause some issues, so we only type the false. Guessing this discrepancy will be solved in Nuxt3.Checklist: