Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): build.html.minify can be false #8835

Merged
merged 2 commits into from
Feb 16, 2021
Merged

fix(types): build.html.minify can be false #8835

merged 2 commits into from
Feb 16, 2021

Conversation

harlan-zw
Copy link
Contributor

Types of changes

Types

Description

The build.html.minify option isn't typed correctly.

It's passed to:

Because it's also used in the generate code, if it was typed to be able to use 'auto' or true it may cause some issues, so we only type the false. Guessing this discrepancy will be solved in Nuxt3.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why) - no logic changes
  • [] All new and existing tests are passing. - tests are throwing a lot of weird unrelated errors, maybe environment-dependent

@harlan-zw harlan-zw changed the title Chore/update minify type chore(types): add false type to html minify Feb 16, 2021
@pi0 pi0 changed the title chore(types): add false type to html minify fix(types): build.html.minify can be false Feb 16, 2021
@pi0 pi0 merged commit b4a31d7 into nuxt:dev Feb 16, 2021
@pi0
Copy link
Member

pi0 commented Feb 16, 2021

Thanks!

@pi0 pi0 mentioned this pull request Feb 19, 2021
This was referenced Mar 10, 2021
This was referenced Mar 12, 2021
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants