-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warning for NuxtPage
absence is always shown if setPageLayout
is called in middleware
#25617
Comments
Start a new pull request in StackBlitz Codeflow. |
Checking, this looks correct to me. Neither of those layouts has a |
Ah, I overlooked that point! Here is the fixed version of the reproduction, and yes the warning is not shown with https://stackblitz.com/edit/github-wgg4gm-qyvjee I believe this issue can be closed for now 👍 You might want to add |
Thanks for the clarification. I can confirm that the warning disappears if we have proper Slots inside the layouts. Sorry for missing that. 🙈 EDIT: Issue can be closed - I think I cannot close it, right? Anyways thanks and keep up the good work! |
For the repository governance, I will leave the closing operation to you 🙋♂️ |
Thank you all for the investigation and faithful reproductions ❤️ |
Environment
Darwin
v21.5.0
3.10.0
3.10.0
2.8.1
npm@10.2.4
-
devtools
-
-
But I believe this bug happens in all environments.
Reproduction
Original reproduction by @robert-gruner
https://stackblitz.com/~/edit/github-wgg4gm-sdfzwd
Minimal reproduction by me
https://stackblitz.com/edit/github-wgg4gm-8hhehw
Describe the bug
This issue is an edge case which was not tested in #25490.
With the
content.global.ts
, which dynamically changes layout, the warning message is always shown.Without the middleware (i.e. without calling
setPageLayout
), the warning message is shown expectedly.Additional context
This issue and the reproduction were originally reported by @robert-gruner as #25490 (comment).
Logs
No response
The text was updated successfully, but these errors were encountered: