Add better support for pug #1361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using `lang="pug"`, passing Boolean `true` as prop and using directives will case errors. See: vuejs/vue-loader#693 vuejs/vue-loader#55 For example: ```html <template lang="pug"> foo( bar v-baz-directive ) </template> ``` This will be rendered as `<foo bar="bar" v-baz-directive="v-baz-directive">` and cause errors such as `bar expected Boolean but got String` and `v`/`baz`/`directive` not defined.
Codecov Report
@@ Coverage Diff @@
## dev #1361 +/- ##
=======================================
Coverage 93.04% 93.04%
=======================================
Files 12 12
Lines 748 748
=======================================
Hits 696 696
Misses 52 52
Continue to review full report at Codecov.
|
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
lang="pug", passing Booleantrueas prop and using directives will case errors.See:
vuejs/vue-loader#693
vuejs/vue-loader#55
For example:
This will be rendered as
<foo bar="bar" v-baz-directive="v-baz-directive">and cause errors such as
bar expected Boolean but got Stringandv/baz/directivenot defined.