Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add better support for pug #1361

Merged
merged 2 commits into from
Aug 13, 2017
Merged

Add better support for pug #1361

merged 2 commits into from
Aug 13, 2017

Commits on Aug 13, 2017

  1. Add better support for pug 

    When using `lang="pug"`, passing Boolean `true` as prop and using directives will case errors.

See: 
vuejs/vue-loader#693
vuejs/vue-loader#55

For example:

```html
<template lang="pug">
foo(
  bar
  v-baz-directive
)
</template>
```

This will be rendered as
`<foo bar="bar" v-baz-directive="v-baz-directive">`
and cause errors such as `bar expected Boolean but got String` and `v`/`baz`/`directive` not defined.
    @DaxChen
    DaxChen committed Aug 13, 2017
    Configuration menu
    Copy the full SHA
    97076fa View commit details
    Browse the repository at this point in the history

  2. use single quotes

    @DaxChen
    DaxChen committed Aug 13, 2017
    Configuration menu
    Copy the full SHA
    90b19e0 View commit details
    Browse the repository at this point in the history