Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(nuxi): Improve server listening when 3000 already used #19578

Closed
wants to merge 1 commit into from
Closed

fix(nuxi): Improve server listening when 3000 already used #19578

wants to merge 1 commit into from

Conversation

yangxiuxiu1115
Copy link

@yangxiuxiu1115 yangxiuxiu1115 commented Mar 10, 2023 •
edited

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

fixed #19560 ,Improve server listening when 3000 already used

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codesandbox
Copy link

codesandbox bot commented Mar 10, 2023

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@danielroe danielroe requested a review from pi0 March 12, 2023 22:27
pi0
pi0 reviewed Mar 13, 2023
View reviewed changes
packages/nuxi/src/commands/dev.ts
port: args.port || args.p || process.env.NUXT_PORT || config.devServer.port,
port: {
port: args.port || args.p || process.env.NUXT_PORT || config.devServer.port,
portRange: [3000, 3100]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we could use it as default in listhen directly to use other fallbacks (actually this was behavior for trying 3000 + a range but behavior regressed as result of another fix)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, so let's resolve upstream in listhen rather than here. 👍

whack-a-mole

Copy link
Member

@atinux atinux Mar 13, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, it seems to be a regression in listhen but thank you very much for the PR @RicardoErii ❤️

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's okay, so I close this PR?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep it open until unjs/listhen#62 is fixed

@atinux atinux mentioned this pull request Mar 13, 2023
Closed
@pi0
Copy link
Member

pi0 commented Mar 13, 2023

The issue should be fixed with listhen@1.0.4

@danielroe danielroe closed this Mar 13, 2023
@danielroe danielroe mentioned this pull request Mar 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atinux atinux atinux left review comments

@pi0 pi0 pi0 left review comments

@danielroe danielroe danielroe left review comments

Assignees
No one assigned
Labels
3.x cli dx 🍰 p2-nice-to-have
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve server listening when 3000 already used
4 participants
@yangxiuxiu1115 @pi0 @atinux @danielroe